-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Add AzureML in integrations via dedicated callback #8062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There is just a conflict to solve (probably with MLFlow merged this morning) and the CI tools to make happy (your import might need some comment to be ignored by black/isort).
|
Code changes pass tests @sgugger ! Thanks @alvarobartt for having a look at those also. I guess I need to take care of docs/source/main_classes/callback.rst as well to complete the checklist though? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything keeps the standards and passes all the checks (black, isort) 👍🏻
|
Yes, if you could add a line to the rst file, that would be great! |
|
You might need to rebase to have the latest script for doc formatting, which should do everything to make the CI happy with just |
LysandreJik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
As you mention hacktoberfest, we had not thought of adding the label but we just did. I hope this PR will be counted towards your goal!
What does this PR do?
I propose this PR to allow transformers to call AzureML logging using https://docs.microsoft.com/en-us/python/api/azureml-core/azureml.core.run(class)?view=azure-ml-py
The intended behaviour is to enable
transformersusers to track metrics in the AzureML UI in this fashionContributors to https://github.com/microsoft/AzureML-BERT and folks @microsoft may well come up with a better implementation though!
I am glad to improve the following if reviewers like the idea, and update docs and tests if needed.
@reviewers feel free to add any suggestions as my contributions to transformers have been very limited so far :)
Before submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@julien-c is aware of this and @sgugger participated in the thread on forums above and implemented callbacks with #7596