-
Notifications
You must be signed in to change notification settings - Fork 31.9k
[fsmt test] basic config test with online model + super tiny model #7860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi Stas, thanks, #7659 will fix this (we will now require at least one example checkpoint for each tokenizer and we test it automatically). |
|
@thomwolf, I'm not certain why you closed this. This is a tokenizer test that is needed - the issue caught in examples was just a flag that there was a missing test in the normal tests. Actually, not only it's needed, I will have to expand this test to verify that it doesn't get the hardcoded default values, but fetches the correct values from Feel free to add it as part of #7659 but please make sure you used different from I hope this makes sense. |
|
Hmm, but you copied I haven't read the new code in depth, but my gut feeling is that the defaults may mask a problem. |
|
Hi stas, I'll let you read the new code and then we can have a look together. The basic idea is that we now require a full and working checkpoint for the tokenizers to be fully tested in various conditions and the slow vs. fast compared. The question of testing that tokenizers load and use |
|
That works. But please re-open this PR, since we need it anyway. I will add more changes to it after your big PR merge to ensure that the loading of the tokenizer is properly tested. |
|
This PR is complete now. |
LysandreJik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR does:
@LysandreJik, @sshleifer