Skip to content

Conversation

@stas00
Copy link
Contributor

@stas00 stas00 commented Sep 15, 2020

Here are the various build/eval/gen scripts used for fsmt. We will use them in the future should any updates/corrections need to be done.

They are also a great starter for porting other similar architectures.

Fixes #7092

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #7155 into master will increase coverage by 3.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7155      +/-   ##
==========================================
+ Coverage   78.44%   81.56%   +3.11%     
==========================================
  Files         168      168              
  Lines       32309    32309              
==========================================
+ Hits        25346    26352    +1006     
+ Misses       6963     5957    -1006     
Impacted Files Coverage Δ
src/transformers/tokenization_xlnet.py 66.66% <0.00%> (-23.43%) ⬇️
src/transformers/tokenization_ctrl.py 78.64% <0.00%> (-17.48%) ⬇️
src/transformers/modeling_transfo_xl_utilities.py 52.98% <0.00%> (-13.44%) ⬇️
src/transformers/modeling_transfo_xl.py 67.10% <0.00%> (-12.67%) ⬇️
src/transformers/modeling_mobilebert.py 79.21% <0.00%> (-10.25%) ⬇️
src/transformers/modeling_t5.py 76.70% <0.00%> (-6.07%) ⬇️
src/transformers/tokenization_dpr.py 53.15% <0.00%> (-4.51%) ⬇️
src/transformers/modeling_utils.py 86.69% <0.00%> (-0.54%) ⬇️
src/transformers/file_utils.py 82.84% <0.00%> (-0.25%) ⬇️
src/transformers/data/data_collator.py 93.18% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ffda9...cdec73c. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a nice addition and can be a good reference if newer models are out.

@sgugger
Copy link
Collaborator

sgugger commented Sep 16, 2020

Good for me too!

@sgugger sgugger merged commit d3391c8 into huggingface:master Sep 16, 2020
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
* build/eval/gen-card scripts for fsmt

* adjust for model renames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

needing area to put download/convert/eval scripts

3 participants