-
Notifications
You must be signed in to change notification settings - Fork 31.9k
[docstring] misc arg doc corrections #6932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix docstring s/int/bool/
Codecov Report
@@ Coverage Diff @@
## master #6932 +/- ##
==========================================
+ Coverage 77.70% 79.53% +1.83%
==========================================
Files 161 161
Lines 30119 30119
==========================================
+ Hits 23403 23956 +553
+ Misses 6716 6163 -553
Continue to review full report at Codecov.
|
|
Thanks. Will in these fixes don't hesitate to replace the True or False by :obj:`True` and :obj:`False` for consistency (also don't hesitate to tag me on doc PR for quicker reviews :-) ) |
|
Understood! Do we have a model of perhaps one largish module that we can use a reference for how the rest should be done? So that you polish the hell out of it, and then this will be the model to follow. |
|
|
|
Great tips on the model docs and the small specifics. I see some are already here: Loving params subgroup docs - it's very helpful. I'd organize the params in the function in the same groups too. Thank you for sharing all these, @sgugger! |
|
Yes we could add those general rules to that section of the docs README. (I am unsure people actually read that so did not take the time to properly update it :-) ) |
|
I didn't know it was there, but now that I do, I'd definitely per-use it - so yes, please update it! |
might be easy to replace in one swoop. |
|
Feel free to do it in one PR :-) |
|
Done: #6956 |
* correct bool types fix docstring s/int/bool/ * fix description * fix num_labels to match reality
Uh oh!
There was an error while loading. Please reload this page.