-
Notifications
You must be signed in to change notification settings - Fork 33.9k
ElectraForMultipleChoice #4954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sgugger
merged 8 commits into
huggingface:master
from
patil-suraj:electra-for-multiple-choice
Jun 18, 2020
Merged
ElectraForMultipleChoice #4954
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
62a10e3
add ElectraForMultipleChoice
patil-suraj 7dcc5c0
add test_for_multiple_choice
patil-suraj 54c9674
add ElectraForMultipleChoice in auto model
patil-suraj 8b3c81d
add ElectraForMultipleChoice in all_model_classes
patil-suraj b01ce7c
add SequenceSummary related parameters
patil-suraj c2b9d68
get rid pooler, use SequenceSummary instead
patil-suraj c7ec642
Merge branch 'master' into electra-for-multiple-choice
LysandreJik 9cb71f9
add electra multiple choice test
patil-suraj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of introducing a new class, I'd rather use the existing
SequenceSummarywhich can do the pool + dropout (see theXLNetForMultipleChoicefor an example. It will require to add a few things to the config to make it work (seeXLNetConfigfor an example).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I wasn't aware of
SequenceSummary. I'll try to use it instead ofPoolerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But couldn't you just use the
ElectraClassificationHeadfor that pooling 🤔:transformers/src/transformers/modeling_electra.py
Lines 346 to 362 in 86578bb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly no, because it adds a linear layer to
num_labels