Add check_model_inits.py - #47656
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
reviewed
Aug 4, 2026
Cyrilvallez
left a comment
Cyrilvallez
left a comment
Member
There was a problem hiding this comment.
Very nice! Let's simply overwrite the old one though, no need to keep it inside the lib! Allowed me to open #47764 with the inexistent models lol
Member
Author
|
Thanks for the review, updated! Always nice to get rid of some old unused code 馃槆 |
Contributor
CI recapDashboard: View test results in Grafana |
Cyrilvallez
approved these changes
Aug 7, 2026
Cyrilvallez
left a comment
Cyrilvallez
left a comment
Member
There was a problem hiding this comment.
Perfect thanks a lot, very welcome qol improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Automatically checks and generates
src/transformers/models/__init__.pythroughcheck_model_inits.py.The file used to be checked by
check_inits.pybut those checks are skipped since ~1y (#36827).I created a new file instead of modifying
check_inits.pyto keep it clean and not mess with the old one. Happy to merge/overwrite if that is preferred.If this PR looks good I think we can also auto-generate most
models/<model>/__init__.pyfiles as they follow a pretty standard schema. Draft PR for follow-up is here: guarin#2Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@Cyrilvallez