Clearer type hints and fix rope validation in configs#44943
Merged
zucchini-nlp merged 3 commits intohuggingface:mainfrom Mar 23, 2026
Merged
Clearer type hints and fix rope validation in configs#44943zucchini-nlp merged 3 commits intohuggingface:mainfrom
zucchini-nlp merged 3 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hmellor
approved these changes
Mar 23, 2026
zucchini-nlp
commented
Mar 23, 2026
Comment on lines
+4218
to
+4225
| # `fields(cls)` returns only the annotations defined on cls exclduing `ClassVar` | ||
| # (e.g. model_type). Also exclude two quasi-ClassVar fields which can `setattr` and | ||
| # saved in config. These do not act as class attributes and thus cannot be `ClassVar` | ||
| # in its general sense. | ||
| own_config_params = { | ||
| field.name for field in fields(cls) if field.name not in ["transformers_version", "architectures"] | ||
| } | ||
| allowed_params = own_config_params if own_config_params else None |
Member
Author
There was a problem hiding this comment.
Almost same as in Yoni's upcoming PR, and I needed it to skip transformers_version/architectures from raising warnings
These two fields are not 100% class attributes in general sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@hmellor