Skip to content

deepseek_v2, deepseek_v3, and modernbert fix for having incorrect tokenizer class on the hub#44801

Merged
hmellor merged 3 commits intomainfrom
update_incorrect_model_list
Mar 18, 2026
Merged

deepseek_v2, deepseek_v3, and modernbert fix for having incorrect tokenizer class on the hub#44801
hmellor merged 3 commits intomainfrom
update_incorrect_model_list

Conversation

@itazap
Copy link
Copy Markdown
Collaborator

@itazap itazap commented Mar 17, 2026

deepseek_v2, deepseek_v3, and modernbert fix for having incorrect tokenizer class on the hub

fixes: #44779, #44783

@itazap itazap requested a review from hmellor March 17, 2026 17:43
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@itazap itazap changed the title deepseek and modernbert deepseek_v3 and modernbert fix for having incorrect tokenizer class on the hub Mar 17, 2026
@itazap itazap changed the title deepseek_v3 and modernbert fix for having incorrect tokenizer class on the hub deepseek_v2, deepseek_v3, and modernbert fix for having incorrect tokenizer class on the hub Mar 18, 2026
@itazap itazap requested a review from ArthurZucker March 18, 2026 14:01
Copy link
Copy Markdown
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modernebert test missing!

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

@itazap itazap added this pull request to the merge queue Mar 18, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 18, 2026
@hmellor hmellor added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 16a5b09 Mar 18, 2026
29 checks passed
@hmellor hmellor deleted the update_incorrect_model_list branch March 18, 2026 21:35
YujiaBao added a commit to YujiaBao/tinker-cookbook that referenced this pull request Mar 20, 2026
transformers 5.3.0 has a known bug that strips spaces during decode
for the DeepSeek tokenizer (huggingface/transformers#44801). Skip
affected tests on exactly 5.3.0 (will resume on 5.3.1+) and emit a
runtime warning when DeepSeek renderers are initialized with 5.3.0.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deepseek tokenizer produces incorrect results as of v5 (works in v4)

4 participants