Skip to content

Add apply_yarn_scaling as optional key to yarn#44747

Closed
juliendenize wants to merge 2 commits intohuggingface:mainfrom
juliendenize:apply_yarn_scaling_ignore
Closed

Add apply_yarn_scaling as optional key to yarn#44747
juliendenize wants to merge 2 commits intohuggingface:mainfrom
juliendenize:apply_yarn_scaling_ignore

Conversation

@juliendenize
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR adds apply_yarn_scaling as an optional key for yarn repo.

This was requested as part of a vLLM PR vllm-project/vllm#37104 that seeks to silence some rope issues when converting Mistral config to HF one.

cc @hmellor

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Copy Markdown
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get a second review from a Transformers team member though

@juliendenize
Copy link
Copy Markdown
Contributor Author

LGTM, let's get a second review from a Transformers team member though

yes, maybe @ArthurZucker @Cyrilvallez are the most suited for this ?

@hmellor
Copy link
Copy Markdown
Member

hmellor commented Mar 16, 2026

Sorry for the back and forth @juliendenize, I have just found that there is a better solution we can implement on the vLLM side.

@hmellor hmellor closed this Mar 16, 2026
@juliendenize
Copy link
Copy Markdown
Contributor Author

Yes thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants