Skip to content

Fix: Conditionally import torch.distributed.fsdp in trainer_seq2seq.py #44507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3outeille merged 4 commits into from
Mar 9, 2026
+4 −2
Merged

Fix: Conditionally import torch.distributed.fsdp in trainer_seq2seq.py #44507

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0872639
fix: conditionally import torch.distributed.fsdp in trainer_seq2seq
Mar 6, 2026
0a1c537
fix: sort imports in trainer_seq2seq.py
Mar 7, 2026
9cca87c
Merge branch 'main' into fix-torch-distributed-import
3outeille Mar 9, 2026
fb0ac7d
Merge branch 'main' into fix-torch-distributed-import
3outeille Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/transformers/trainer_seq2seq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import torch
from torch import nn
from torch.distributed.fsdp import FullyShardedDataParallel
from torch.utils.data import Dataset

from .generation.configuration_utils import GenerationConfig
Expand All @@ -30,6 +29,9 @@
from .utils import is_datasets_available, logging


if torch.distributed.is_available():
from torch.distributed.fsdp import FullyShardedDataParallel

if is_datasets_available():
import datasets

Expand Down Expand Up @@ -319,7 +321,7 @@ def prediction_step(

summon_full_params_context = (
FullyShardedDataParallel.summon_full_params(self.model)
if isinstance(self.model, FullyShardedDataParallel)
if torch.distributed.is_available() and isinstance(self.model, FullyShardedDataParallel)
else contextlib.nullcontext()
)

Expand Down