[vLLM] Fix backward compatibility with hardcoded subprocessors classes in processors#44447
Merged
yonigozlan merged 3 commits intohuggingface:mainfrom Mar 5, 2026
Conversation
zucchini-nlp
approved these changes
Mar 5, 2026
Member
zucchini-nlp
left a comment
zucchini-nlp
left a comment
There was a problem hiding this comment.
Thanks. Only one q: should we raise a warning or anything, that a cls attr is deprecated and to be removed in the future?
hmellor
approved these changes
Mar 5, 2026
Member
hmellor
left a comment
hmellor
left a comment
There was a problem hiding this comment.
I've confirmed that this fixes the issue on the vLLM side. I agree a warning would be good.
Member
Author
|
Added the warning, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes MiniCPM-o-2_6 related tests failures in vLLM, and improve backward compatibility with remote code in general.
Cc @hmellor @zucchini-nlp