Dynamic weight conversion is recursive by zucchini-nlp · Pull Request #44300 · huggingface/transformers

zucchini-nlp · 2026-02-26T14:09:59Z

What does this PR do?

The recursive feature is needed for me in #44252 to allow timm backbone define its conversion only once. Also it currently allows to delete "t5gemma2" from conversion, allowing its backbones to rename weight

HuggingFaceDocBuilderDev · 2026-02-26T14:33:26Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

zucchini-nlp · 2026-02-26T19:02:09Z

run-slow: colpali, colqwen2, emu3, ernie4_5_vl_moe, fuyu, gemma3, gemma3n, glm4v, qwen2_vl, maskformer, llava, sam3, qwen3_5

zucchini-nlp · 2026-02-26T20:07:52Z

run-slow: colpali, colqwen2, emu3, ernie4_5_vl_moe, fuyu, gemma3, gemma3n, glm4v, qwen2_vl, maskformer, llava, sam3, qwen3_5

github-actions · 2026-02-26T20:08:59Z

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/colpali", "models/colqwen2", "models/emu3", "models/ernie4_5_vl_moe", "models/fuyu", "models/gemma3", "models/gemma3n", "models/glm4v", "models/llava", "models/maskformer", "models/qwen2_vl", "models/qwen3_5", "models/sam3"]
quantizations: []

github-actions · 2026-02-26T21:25:08Z

CI Results

Workflow Run ⚙️

Commit Info

Context	Commit	Description
RUN	a7702f43	workflow commit (merge commit)
PR	ea3ac63a	branch commit (from PR)
main	b812aa91	base commit (on `main`)

Model CI Report

❌ 8 new failed tests from this PR 😭

colpali:
tests/models/colpali/test_modeling_colpali.py::ColPaliModelIntegrationTest::test_model_integration_test (✅ ⟹ ❌)
colqwen2:
tests/models/colqwen2/test_modeling_colqwen2.py::ColQwen2ForRetrievalModelTest::test_reverse_loading_mapping (✅ ⟹ ❌)
emu3:
tests/models/emu3/test_modeling_emu3.py::Emu3IntegrationTest::test_model_generate_images (❌ ⟹ ❌)
tests/models/emu3/test_modeling_emu3.py::Emu3IntegrationTest::test_model_generation (❌ ⟹ ❌)
tests/models/emu3/test_modeling_emu3.py::Emu3IntegrationTest::test_model_generation_batched (❌ ⟹ ❌)
tests/models/emu3/test_modeling_emu3.py::Emu3IntegrationTest::test_model_generation_multi_image (❌ ⟹ ❌)
fuyu:
tests/models/fuyu/test_modeling_fuyu.py::FuyuModelIntegrationTest::test_greedy_generation (❌ ⟹ ❌)
llava:
tests/models/llava/test_modeling_llava.py::LlavaForConditionalGenerationIntegrationTest::test_pixtral (❌ ⟹ ❌)

zucchini-nlp · 2026-02-27T11:36:17Z

run-slow: colpali, colqwen2, ernie4_5_vl_moe, fuyu, gemma3, gemma3n, glm4v, qwen2_vl, maskformer, llava, sam3, qwen3_5

github-actions · 2026-02-27T11:37:27Z

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/colpali", "models/colqwen2", "models/ernie4_5_vl_moe", "models/fuyu", "models/gemma3", "models/gemma3n", "models/glm4v", "models/llava", "models/maskformer", "models/qwen2_vl", "models/qwen3_5", "models/sam3"]
quantizations: []

zucchini-nlp · 2026-02-27T12:04:38Z

Should be ready now, failing qwen3-5-moe is not related. It has been failing on main for a long time and is related to expert impl

github-actions · 2026-02-27T12:46:20Z

CI Results

Workflow Run ⚙️

Commit Info

Context	Commit	Description
RUN	a6785476	workflow commit (merge commit)
PR	500e96b0	branch commit (from PR)
main	7d511b6a	base commit (on `main`)

⚠️ Model CI failed to report results

The test failure analysis could not be completed. Please check the workflow run for details.

github-actions · 2026-03-24T11:12:21Z

[For maintainers] Suggested jobs to run (before merge)

run-slow: conditional_detr, detr, edgetam, fast_vlm, maskformer, pe_audio_video, pe_video, perception_lm

github-actions · 2026-03-24T11:24:15Z

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44300&sha=7e3d40

github-actions · 2026-03-25T13:08:38Z

[For maintainers] Suggested jobs to run (before merge)

run-slow: conditional_detr, detr, edgetam, fast_vlm, maskformer, pe_audio_video, pe_video, perception_lm

zucchini-nlp · 2026-03-25T13:25:28Z

@bot /repo

github-actions · 2026-03-25T13:26:11Z

Repo. Consistency bot fixed some files and pushed the changes.

github-actions · 2026-03-25T13:31:25Z

[For maintainers] Suggested jobs to run (before merge)

run-slow: conditional_detr, detr, edgetam, fast_vlm, maskformer, pe_audio_video, pe_video, perception_lm

zucchini-nlp · 2026-03-25T13:34:58Z

@bot /style

github-actions · 2026-03-25T13:35:41Z

Style fix fix runs successfully without any file modified.

github-actions · 2026-03-25T13:42:34Z

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44300&sha=df86ff

github-actions · 2026-03-25T14:02:00Z

[For maintainers] Suggested jobs to run (before merge)

run-slow: conditional_detr, detr, edgetam, fast_vlm, maskformer, pe_audio_video, pe_video, perception_lm

github-actions · 2026-03-25T14:15:51Z

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44300&sha=ebcb04

github-actions · 2026-03-25T15:50:50Z

[For maintainers] Suggested jobs to run (before merge)

run-slow: conditional_detr, detr, edgetam, fast_vlm, maskformer, pe_audio_video, pe_video, perception_lm

github-actions · 2026-03-25T16:16:08Z

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=44300&sha=99f0a0

github-actions · 2026-03-26T11:18:21Z

[For maintainers] Suggested jobs to run (before merge)

run-slow: conditional_detr, detr, edgetam, fast_vlm, maskformer, pe_audio_video, pe_video, perception_lm

* split out from timm PR * all other VLMs * timm backbone is not here * oops, extra key is breaking eveerything * . * this test * maybe * fix missing keys when loading from hub * now fix fast tests * merge gone wrong * fix repo * refine the regex again! * close the bracket * Apply suggestions from code review Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com> * revert unrelated * ! * revert more * add submodule prefix when recursing * i'll need to fix maskformer later * dont duplicate the same pattern twice * fix modular * detr * colpali isn't working still! * oke, so this can be fine for now * ! * revert * dot lost in regex and comments * timm wrapper is weird * skip these, timm wrapper * bye bye timm * make repo check happy * Revert "bye bye timm" This reverts commit ca68663. * love timm! * Apply repo consistency fixes * oke, the bot can't fix it so here we go --------- Co-authored-by: Anton Vlasjuk <73884904+vasqu@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

zucchini-nlp added 3 commits February 26, 2026 14:37

split out from timm PR

2c1d904

all other VLMs

0caafab

timm backbone is not here

edb4d27

zucchini-nlp commented Feb 26, 2026

View reviewed changes

Comment thread src/transformers/conversion_mapping.py Outdated

zucchini-nlp added 4 commits February 26, 2026 15:41

oops, extra key is breaking eveerything

cbbecf4

.

1fd89ae

this test

0a4a829

maybe

af57e2e

Merge branch 'main' into convert-weights-recursive

ea3ac63

zucchini-nlp added 6 commits February 27, 2026 11:41

fix missing keys when loading from hub

fbda051

now fix fast tests

88f18be

Merge branch 'main' into convert-weights-recursive

6eb0e13

merge gone wrong

b9f29ab

fix repo

d452817

refine the regex again!

500e96b

zucchini-nlp commented Feb 27, 2026

View reviewed changes

Comment thread src/transformers/conversion_mapping.py

zucchini-nlp commented Feb 27, 2026

View reviewed changes

Comment thread src/transformers/conversion_mapping.py Outdated

zucchini-nlp commented Feb 27, 2026

View reviewed changes

Comment thread src/transformers/core_model_loading.py Outdated

zucchini-nlp commented Feb 27, 2026

View reviewed changes

Comment thread src/transformers/core_model_loading.py Outdated

zucchini-nlp commented Feb 27, 2026

View reviewed changes

Comment thread tests/models/mllama/test_modeling_mllama.py Outdated

zucchini-nlp requested a review from Cyrilvallez February 27, 2026 12:04

Merge branch 'main' into convert-weights-recursive

29e600a

Apply repo consistency fixes

df86ff7

oke, the bot can't fix it so here we go

ebcb04f

zucchini-nlp enabled auto-merge March 25, 2026 14:07

yonigozlan mentioned this pull request Mar 25, 2026

🚨 Refactor ViT to updated standards #41693

Open

77 tasks

Merge branch 'main' into convert-weights-recursive

99f0a05

Merge branch 'main' into convert-weights-recursive

58e0d1c

zucchini-nlp added this pull request to the merge queue Mar 26, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 26, 2026

zucchini-nlp added this pull request to the merge queue Mar 26, 2026

Merged via the queue into huggingface:main with commit 09832b2 Mar 26, 2026
29 checks passed

zucchini-nlp deleted the convert-weights-recursive branch March 26, 2026 11:59

vasqu mentioned this pull request Mar 26, 2026

Add RF-DETR #36895

Open

5 tasks

Conversation

zucchini-nlp commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

Uh oh!

HuggingFaceDocBuilderDev commented Feb 26, 2026

Uh oh!

zucchini-nlp commented Feb 26, 2026

Uh oh!

zucchini-nlp commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

Uh oh!

github-actions bot commented Feb 26, 2026

CI Results

Commit Info

Model CI Report

Uh oh!

zucchini-nlp commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zucchini-nlp commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

CI Results

Commit Info

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

zucchini-nlp commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

zucchini-nlp commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zucchini-nlp commented Feb 26, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading