Add Jina-Embeddings-V3 Model#44251
Conversation
vasqu
left a comment
There was a problem hiding this comment.
Before going through a full review, I noticed that some custom implementation of LoRA was used. Imo, it doesn't really make sense when we have PEFT and especially the loading and saving logic should be handled with these - it's super non-standard and will create a lot of maintenance burden on us.
Is there a way to restructure the models for this? I.e. using PEFT instead with the adapters being separately loadable
src/transformers/models/jina_embeddings_v3/modular_jina_embeddings_v3.py
Outdated
Show resolved
Hide resolved
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Yep, checking internally to get you into a slack channel 🫡 will ping you here when I have updates |
|
run-slow: jina_embeddings_v3 |
|
This comment contains models: ["models/jina_embeddings_v3"] |
|
run-slow: jina_embeddings_v3 |
|
run-slow: jina_embeddings_v3 |
|
Workflow Run ⚙️💔 This comment contains |
|
run-slow: jina_embeddings_v3 |
|
This comment contains models: ["models/jina_embeddings_v3"] |
|
Will wait for tomorrow CI is really struggling and I dont want to merge in this state. Re slack I will ping you here probably when I have updates. Thanks a lot for contributing 🤗 |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, jina_embeddings_v3 |
Sure. Thank you..👍🏻! |
|
@Sai-Suraj-27 you should have received an email |
What does this PR do?
Model Page: https://huggingface.co/jinaai/jina-embeddings-v3
Model Paper: https://huggingface.co/papers/2409.10173
Downloads last month > 5.3M
Completes Part of #42738
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@vasqu @ArthurZucker