Skip to content

Add Jina-Embeddings-V3 Model#44251

Merged
vasqu merged 74 commits intohuggingface:mainfrom
Sai-Suraj-27:add_jina_v3_model
Mar 18, 2026
Merged

Add Jina-Embeddings-V3 Model#44251
vasqu merged 74 commits intohuggingface:mainfrom
Sai-Suraj-27:add_jina_v3_model

Conversation

@Sai-Suraj-27
Copy link
Copy Markdown
Contributor

What does this PR do?

Model Page: https://huggingface.co/jinaai/jina-embeddings-v3
Model Paper: https://huggingface.co/papers/2409.10173
Downloads last month > 5.3M

Completes Part of #42738

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@vasqu @ArthurZucker

Copy link
Copy Markdown
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before going through a full review, I noticed that some custom implementation of LoRA was used. Imo, it doesn't really make sense when we have PEFT and especially the loading and saving logic should be handled with these - it's super non-standard and will create a lot of maintenance burden on us.

Is there a way to restructure the models for this? I.e. using PEFT instead with the adapters being separately loadable

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@vasqu vasqu disabled auto-merge March 18, 2026 16:48
@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Mar 18, 2026

Yep, checking internally to get you into a slack channel 🫡 will ping you here when I have updates

@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Mar 18, 2026

run-slow: jina_embeddings_v3

@github-actions
Copy link
Copy Markdown
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/jina_embeddings_v3"]
quantizations: []

@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Mar 18, 2026

run-slow: jina_embeddings_v3

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 4f68b330 workflow commit (merge commit)
PR f71b4ba2 branch commit (from PR)
main 4ec84a02 base commit (on main)

⚠️ No test being reported (jobs are skipped or cancelled)!

@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Mar 18, 2026

run-slow: jina_embeddings_v3

@github-actions
Copy link
Copy Markdown
Contributor

Workflow Run ⚙️💔 This comment contains run-slow, but unknown error occurred and the workflow run aborted!

@huggingface huggingface deleted a comment from github-actions bot Mar 18, 2026
@huggingface huggingface deleted a comment from github-actions bot Mar 18, 2026
@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Mar 18, 2026

run-slow: jina_embeddings_v3

@github-actions
Copy link
Copy Markdown
Contributor

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/jina_embeddings_v3"]
quantizations: []

@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Mar 18, 2026

@Sai-Suraj-27

Will wait for tomorrow CI is really struggling and I dont want to merge in this state. Re slack I will ping you here probably when I have updates.

Thanks a lot for contributing 🤗

@github-actions
Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto, jina_embeddings_v3

@github-actions
Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN ac2ae0c3 workflow commit (merge commit)
PR e5c6f354 branch commit (from PR)
main 24a4dc22 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@Sai-Suraj-27
Copy link
Copy Markdown
Contributor Author

Yep, checking internally to get you into a slack channel 🫡 will ping you here when I have updates

Will wait for tomorrow CI is really struggling and I dont want to merge in this state. Re slack I will ping you here probably when I have updates.

Thanks a lot for contributing 🤗

Sure. Thank you..👍🏻!

@vasqu vasqu enabled auto-merge March 18, 2026 17:44
@vasqu vasqu added this pull request to the merge queue Mar 18, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 18, 2026
@vasqu vasqu added this pull request to the merge queue Mar 18, 2026
Merged via the queue into huggingface:main with commit 2195093 Mar 18, 2026
28 of 29 checks passed
@vasqu
Copy link
Copy Markdown
Contributor

vasqu commented Mar 19, 2026

@Sai-Suraj-27 you should have received an email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants