Fix image processors from_dict backward compatibility with old remote code#44245
Merged
yonigozlan merged 3 commits intohuggingface:mainfrom Feb 24, 2026
Merged
Conversation
yonigozlan
force-pushed
the
fix-phi4-vllm-remote-code
branch
from
eda7228 to
1f0dded
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
redpanda1995
approved these changes
Feb 24, 2026
hmellor
reviewed
Feb 24, 2026
Member
There was a problem hiding this comment.
Could we add a warning to let remote code model users know that this is happening?
Also if you were feeling fancy you could iterate over kwargs in reverse and pop them in a single loop
Member
Author
There was a problem hiding this comment.
Added the warning! And I did feel fancy :)
Member
There was a problem hiding this comment.
Oh since we're using list() again I don't think reversed is necessary, since the list is a copy (I think)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix backward compatibility with remote code for old processors not defining valid_kwargs (e.g. phi4)
Cc @zucchini-nlp
Fix
test_processor_overridefor phi3v and phi4 in vllm @hmellor