Merged
Conversation
vasqu
commented
Feb 20, 2026
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
commented
Feb 20, 2026
| def resolve_internal_import(module: ModuleType | None, chained_path: str) -> Callable | ModuleType | None: | ||
| """ | ||
| Check if a given `module` has an internal import path as defined by the `chained_path`. | ||
| This can either be the full path (not exposed in `__init__`) OR the last part of the chain (exposed in `__init__`). |
Contributor
Author
There was a problem hiding this comment.
We are stuck with this either way now because we need BC
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bamba, falcon_h1, falcon_mamba, granitemoehybrid, jamba, mamba, mamba2, zamba, zamba2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our kernel loading is incompatible with the original packages as they do not expose the same import structure:
selective_state_update)This is hard to test as you need to check within multiple different environments what packages are installed and whether things are properly loaded --> mamba2 was silently ignored even though the og pkg was there, mamba1 only luckily forced the issue leading to this discovery