Skip to content

chore(typing): initial ty integration#44167

Merged
tarekziade merged 28 commits intomainfrom
tarekziade-introduce-ty
Feb 20, 2026
Merged

chore(typing): initial ty integration#44167
tarekziade merged 28 commits intomainfrom
tarekziade-introduce-ty

Conversation

@tarekziade
Copy link
Copy Markdown
Collaborator

@tarekziade tarekziade commented Feb 20, 2026

Initial ty integration. To avoid a gigantic, risky patch, let's start with a baby step where we add the tooling to make repo-check and activate it on a subset of the repo.

That gives us a human-readable patch, and allows us to get confortable with the tool before we expand it.

This patch:

  • adds ty to make repo-check and the CI
  • runs only against src/transformers/utils
  • has a large list of ignores in its configuration for now, that we will loosen later

@tarekziade tarekziade mentioned this pull request Feb 20, 2026
Closed
5 tasks
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Feb 20, 2026

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tarekziade tarekziade force-pushed the tarekziade-introduce-ty branch from e6d5682 to d6ecb05 Compare February 20, 2026 08:36
@tarekziade tarekziade self-assigned this Feb 20, 2026
@tarekziade
Copy link
Copy Markdown
Collaborator Author

tarekziade commented Feb 20, 2026

flaky failure reproduced locally, and addressed in #44173

@tarekziade
Copy link
Copy Markdown
Collaborator Author

tarekziade commented Feb 20, 2026

run-slow: dia, whisper

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/dia", "models/whisper"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 8ab47d6c workflow commit (merge commit)
PR d6ecb050 branch commit (from PR)
main 1f468a8b base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

Cyrilvallez
Cyrilvallez approved these changes Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Happy to finally start with ty, and happy to use the private _typing.py to help us!

Comment thread src/transformers/integrations/integration_utils.py Outdated
@tarekziade tarekziade force-pushed the tarekziade-introduce-ty branch from d6ecb05 to 9b57011 Compare February 20, 2026 15:30
@tarekziade
initial ty integration
72d2680
@tarekziade
narrow ty check to utils and add more ignores
3045617
@tarekziade
circleci does not use the makefile, fix ty changes there
f92bb1c
@tarekziade
remove unecessary ignores
5a7ca7e
@tarekziade
removed a couple of ignores
d659552
@tarekziade
causal_mask can be a Tensor, BlockMask or None, lets be explicit
a83625b
@tarekziade
simplify to_json_string
152217d
@tarekziade
make it more readable - we know qc cannot be None here but its best b…
11d2679 
…alance with ty
@tarekziade
explicitely assert training_tracker, do not silently ignore
a6f5fa3
@tarekziade
make _is_package_available return type unique, and fully private to i…
2e5df02 
…ts module
@tarekziade
explicit contract at the base class level is nicer than duck typing c…
eee45da 
…hecks
@tarekziade
add a comment about monky patching the logger
0e34af5
@tarekziade
added ignore
11b998d
@tarekziade
better one
4eb870d
@tarekziade
fixed test
070337a
@tarekziade
tweaks
243b60b
@tarekziade
added a logger protocol
09bc801
@tarekziade
removed some asserts
5851b9a
@tarekziade
just ignore type check on that one
1a78216
@tarekziade tarekziade force-pushed the tarekziade-introduce-ty branch from 9b57011 to 9869da8 Compare February 20, 2026 15:31
@tarekziade
Copy link
Copy Markdown
Collaborator Author

tarekziade commented Feb 20, 2026

run-slow: dia, whisper

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/dia", "models/whisper"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: dia, whisper

@tarekziade
Copy link
Copy Markdown
Collaborator Author

tarekziade commented Feb 20, 2026

run-slow: dia, whisper

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN 83e13b40 workflow commit (merge commit)
PR 9869da84 branch commit (from PR)
main 9887ca2a base commit (on main)

⚠️ No test being reported (jobs are skipped or cancelled)!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2026

Workflow Run ⚙️

This comment contains run-slow, running the specified jobs:

models: ["models/dia", "models/whisper"]
quantizations: []

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 20, 2026

CI Results

Workflow Run ⚙️

Commit Info

Context Commit Description
RUN e976f87f workflow commit (merge commit)
PR b46e11b5 branch commit (from PR)
main 87954470 base commit (on main)

✅ No failing test specific to this PR 🎉 👏 !

@tarekziade tarekziade merged commit 147b7aa into main Feb 20, 2026
27 of 28 checks passed
@tarekziade tarekziade deleted the tarekziade-introduce-ty branch February 20, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cyrilvallez Cyrilvallez Cyrilvallez approved these changes

Assignees

@tarekziade tarekziade

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarekziade @HuggingFaceDocBuilderDev @Cyrilvallez