Skip to content

custom tok init fix#43591

Merged
itazap merged 5 commits intomainfrom
custom_tok_init_fix
Feb 2, 2026
Merged

custom tok init fix#43591
itazap merged 5 commits intomainfrom
custom_tok_init_fix

Conversation

@itazap
Copy link
Collaborator

@itazap itazap commented Jan 29, 2026

custom tokenizers fail on super.init() call that tries to update vocab size before all vocab attrs are defined

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@itazap itazap force-pushed the custom_tok_init_fix branch from c940906 to 8a72251 Compare January 29, 2026 12:36
@itazap itazap requested a review from ArthurZucker January 29, 2026 13:13
@hmellor hmellor added the for patch Tag issues / labels that should be included in the next patch label Jan 30, 2026
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_tokenizer_defaults_preserved_by_kwargs I'm not sure its related no?


@slow
def test_custom_tokenizer_init(self):
tokenizer = AutoTokenizer.from_pretrained("Qwen/Qwen-VL", trust_remote_code=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, but let's make sure we pin latest commit (security)

@itazap itazap force-pushed the custom_tok_init_fix branch from d871cd3 to c8c0523 Compare February 2, 2026 16:27
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

[For maintainers] Suggested jobs to run (before merge)

run-slow: auto

@itazap itazap merged commit f12b50a into main Feb 2, 2026
26 checks passed
@itazap itazap deleted the custom_tok_init_fix branch February 2, 2026 17:00
@itazap
Copy link
Collaborator Author

itazap commented Feb 2, 2026

run-slow: auto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for patch Tag issues / labels that should be included in the next patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants