Skip to content

Fix tied_weights for vlms#42523

Merged
Cyrilvallez merged 30 commits intomainfrom
fix-llavas
Dec 1, 2025
Merged

Fix tied_weights for vlms#42523
Cyrilvallez merged 30 commits intomainfrom
fix-llavas

Conversation

@Cyrilvallez
Copy link
Member

@Cyrilvallez Cyrilvallez commented Dec 1, 2025

What does this PR do?

Minimum fix from #42385

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: kyutai_speech_to_text, llava_next_video, llava_onevision

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think bart and seamless m4t and marian were the most proeminant to test

@Cyrilvallez Cyrilvallez merged commit 1b6b6cd into main Dec 1, 2025
19 checks passed
@Cyrilvallez Cyrilvallez deleted the fix-llavas branch December 1, 2025 16:40
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

sarathc-cerebras pushed a commit to sarathc-cerebras/transformers that referenced this pull request Dec 7, 2025
* one fix

* attempt mistral3

* empty dict

* that was olmoe's problem

* current CI status?

* actual CI status

* simplify

* hmm?

* bird

* force tie word embeddings to false

* specifics of FSMT

* wrong reference?

* finalize

* fixup

* weird mamba error

* fix tied weights

* hack musicgen

* tie_encoder_decoder workaround

* revert unwanted changes

* hardcode llava onevision

* more

* revert

* fix

* modular

* modular

---------

Co-authored-by: Pablo Montalvo <pablo.montalvo.leroux@gmail.com>
Co-authored-by: Pablo Montalvo <39954772+molbap@users.noreply.github.com>
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
* one fix

* attempt mistral3

* empty dict

* that was olmoe's problem

* current CI status?

* actual CI status

* simplify

* hmm?

* bird

* force tie word embeddings to false

* specifics of FSMT

* wrong reference?

* finalize

* fixup

* weird mamba error

* fix tied weights

* hack musicgen

* tie_encoder_decoder workaround

* revert unwanted changes

* hardcode llava onevision

* more

* revert

* fix

* modular

* modular

---------

Co-authored-by: Pablo Montalvo <pablo.montalvo.leroux@gmail.com>
Co-authored-by: Pablo Montalvo <39954772+molbap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants