Add backward compatibility for methods which have been moved to RotaryEmbeddingConfigMixin#42517
Merged
ArthurZucker merged 5 commits intohuggingface:mainfrom Dec 2, 2025
Merged
Conversation
…ryEmbeddingConfigMixin` Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
sarathc-cerebras
pushed a commit
to sarathc-cerebras/transformers
that referenced
this pull request
Dec 7, 2025
…ryEmbeddingConfigMixin` (huggingface#42517) * Add backward compatibility for methods which have been moved to `RotaryEmbeddingConfigMixin` Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * They're not actually no-ops Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * Fix type hint Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * If they're calling this function, they haven't standardised either Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * No need to BC method that wasn't in any releases Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --------- Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…ryEmbeddingConfigMixin` (huggingface#42517) * Add backward compatibility for methods which have been moved to `RotaryEmbeddingConfigMixin` Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * They're not actually no-ops Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * Fix type hint Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * If they're calling this function, they haven't standardised either Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> * No need to BC method that wasn't in any releases Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --------- Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function was moved in #42255. Many custom code models import this function, which is arguably good practise as it shows they are leveraging our first party utilities.
This PR reinstates the function by calling the methods which now live in
RotaryEmbeddingConfigMixinso that these custom code models will continue to work with Transformers v5.