Skip to content

FIX: Minimal fix for loading PEFT weights #42387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 5 commits into from
Nov 27, 2025
Merged

FIX: Minimal fix for loading PEFT weights #42387

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62f6c56
FIX Minimal fix for loading PEFT weights
BenjaminBossan Nov 25, 2025
423fbc6
Allow n:n matching
BenjaminBossan Nov 26, 2025
ee7ea24
Merge branch 'main' into fix-issue-weight-converter-peft
BenjaminBossan Nov 26, 2025
5807a3c
Reviewer feedback
BenjaminBossan Nov 27, 2025
59f051b
Merge branch 'main' into fix-issue-weight-converter-peft
BenjaminBossan Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/transformers/integrations/peft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
import inspect
import json
import os
import re
from typing import Any, Literal

from ..core_model_loading import WeightRenaming, build_glob_alternation, repl
from ..utils import (
CONFIG_NAME,
cached_file,
Expand Down Expand Up @@ -302,12 +302,10 @@ def load_adapter(
else:
new_key = key

if key_mapping: # TODO dynamic weight loader for adapters
for pattern, replacement in key_mapping.items():
new_key, n_replace = re.subn(pattern, replacement, new_key)
# Early exit of the loop
if n_replace > 0:
break
if key_mapping:
renamings = [entry for entry in key_mapping if isinstance(entry, WeightRenaming)]
rename_alt, _, rename_by_group = build_glob_alternation(renamings)
new_key = rename_alt.sub(lambda m: repl(m, rename_by_group), new_key).replace("\\", "")

# For hotswapping, we need the adapter name to be present in the state dict keys
if hotswap:
Expand Down