Fix whisper return language - #42227
Conversation
|
Hi @eustlb have you seen this PR? It fixes the whisper return language, without touching generation_whisper.py, as you requested here: |
|
[For maintainers] Suggested jobs to run (before merge) run-slow: whisper |
|
@eustlb this still needs fixing on latest transformers version. |
|
Thanks for raising this PR and for your patience @FredHaa, reviewing now |
…sformers into fix-whisper-return-language
…sformers into fix-whisper-return-language
There was a problem hiding this comment.
Thanks a lot @FredHaa for your PR 🤗
allowed myself to push to it to finally get that fixed, with only touching at the pipeline's code. We still probably have to update tests values for the one expected on the CI runners. Taking care of that.
|
run-slow: whisper |
|
This comment contains models: ["models/whisper"] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Any idea when this will be merged? |
* Add output language to chunks * Add output language to chunks * Fix formating * Return full language instead of iso code * revert changes (excep test) * correct fix * fix * values for runner --------- Co-authored-by: Eustache Le Bihan <eulebihan@gmail.com> Co-authored-by: eustlb <94853470+eustlb@users.noreply.github.com>
3 participants
What does this PR do?
Fixes #39404
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@eustlb
@ebezzam