Fix rope_parameters for gemma3 weights conversion script #41922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma3 |
5 tasks
Contributor
Member
|
Yes, good fix - |
Rocketknight1
approved these changes
Oct 30, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
i3hz
pushed a commit
to i3hz/transformers
that referenced
this pull request
Oct 30, 2025
…#41922) Fix rope_parameters for gemma3 weights conversion script. Co-authored-by: Douglas Reid <[email protected]>
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
…#41922) Fix rope_parameters for gemma3 weights conversion script. Co-authored-by: Douglas Reid <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the rope_parameters in the weights conversion script for Gemma 3.
These should be: