[Parakeet] add output_attention_mask #41694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
nithinraok
reviewed
Oct 17, 2025
|
|
||
| return BaseModelOutput(last_hidden_state=hidden_states) | ||
| return ParakeetEncoderModelOutput( | ||
| last_hidden_state=hidden_states, attention_mask=output_mask.int() if output_attention_mask else None |
Contributor
There was a problem hiding this comment.
can we return lengths directly instead or along with attention_mask
Contributor
Author
There was a problem hiding this comment.
I'd rather keep an explicit approach here for potiential future usage of the same with left padding, you can retreive lengths by doing attention_mask.sum(-1)
ArthurZucker
approved these changes
Oct 23, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Okay sounds good !
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: parakeet |
ngazagna-qc
pushed a commit
to ngazagna-qc/transformers
that referenced
this pull request
Oct 24, 2025
* add output_attention_mask * style
i3hz
pushed a commit
to i3hz/transformers
that referenced
this pull request
Oct 30, 2025
* add output_attention_mask * style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parakeet encoder modified the sequence length, making that the input attention_mask cannot be directly used to know which embeddings positions correspond to padding.
Here we do it differently than the actual external approach like we have on mimi that consists to retreive the correct mask:
and that recomputes as mask that is already known in the forward and that can simply be returned along with the outputs.