-
Notifications
You must be signed in to change notification settings - Fork 33.7k
[v5] 🚨Refactor subprocessors handling in processors #41633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yonigozlan
merged 29 commits into
huggingface:main
from
yonigozlan:remove-attributes-from-processors
Nov 7, 2025
Merged
Changes from 5 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f48a47b
remove attributes and add all missing sub processors to their auto cl…
yonigozlan d5d5c58
remove all mentions of .attributes
yonigozlan dd505b5
cleanup
yonigozlan 6a1448f
fix processor tests
yonigozlan a292900
fix modular
yonigozlan 63a255d
remove last attributes
yonigozlan ef73759
fixup
yonigozlan b5e8b2e
Merge remote-tracking branch 'upstream/main' into remove-attributes-f…
yonigozlan f14ff3c
fixes after merge
yonigozlan 0306430
fix wrong tokenizer in auto florence2
yonigozlan 01cb815
fix missing audio_processor + nits
yonigozlan 49ec906
Override __init__ in NewProcessor and change hf-internal-testing-repo…
yonigozlan 7dd5682
Merge remote-tracking branch 'upstream/main' into remove-attributes-f…
yonigozlan 946cc5c
fix auto tokenizer test
yonigozlan b0cb3e0
add init to markup_lm
yonigozlan 3b9e846
update CustomProcessor in custom_processing
yonigozlan 53de7a4
remove print
yonigozlan 93d2c4d
Merge branch 'main' into remove-attributes-from-processors
yonigozlan feeec28
Merge remote-tracking branch 'upstream/main' into remove-attributes-f…
yonigozlan 4a6b080
nit
yonigozlan 02402a0
Merge branch 'remove-attributes-from-processors' of https://github.co…
yonigozlan 757e1f1
fix test modeling owlv2
yonigozlan bf763b2
fix test_processing_layoutxlm
yonigozlan 0799a0a
Fix owlv2, wav2vec2, markuplm, voxtral issues
yonigozlan bf1a4b6
Merge remote-tracking branch 'upstream/main' into remove-attributes-f…
yonigozlan e3f130d
add support for loading and saving multiple tokenizer natively
yonigozlan cc45a7e
remove exclude_attributes from save_pretrained
yonigozlan 8979645
modifs after review
yonigozlan 6cc30f9
Merge remote-tracking branch 'upstream/main' into remove-attributes-f…
yonigozlan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,6 +64,7 @@ | |
| ("video_llava", "VideoLlavaVideoProcessor"), | ||
| ("videomae", "VideoMAEVideoProcessor"), | ||
| ("vjepa2", "VJEPA2VideoProcessor"), | ||
| ("video_llama_3", "VideoLlama3VideoProcessor"), # PLACEHOLDER - needs proper video processor class | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes mb, remnants from the script... |
||
| ] | ||
| ) | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this PR, but using
PreTrainedTokenizeras auto-class looks funny 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes not sure if that should be the case @itazap is that expected/is it a potential issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was wondering the same thing 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, why is it added here? I see smollm3 only has the Fast one