-
Notifications
You must be signed in to change notification settings - Fork 32.9k
🚨 Refactor DETR to updated standards #41549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
18e7172
refactor attention and many other
yonigozlan a931c26
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan f7536b9
remove return_dict interface
yonigozlan c016021
improve variable names
yonigozlan 7f21985
use _can_record_outputs and add real support for pixel and queries ma…
yonigozlan d0494e9
split self attention and cross attention
yonigozlan 2f0752f
nits
yonigozlan 67a007a
standardize mask handling
yonigozlan eab4e85
update DetrMHAttentionMap
yonigozlan ac8d387
refactor mlp detr
yonigozlan b82b172
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 4181e50
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan efb8070
make style
yonigozlan 1fc5fe3
remve outdated tests which used ".bin" checkpoints
yonigozlan ed595af
Updates modeling_detr to newest standards
yonigozlan 0827d6b
Review + fix detr weight conversion
yonigozlan 9aeded8
replace einsum, reorder
yonigozlan 1d65bd9
refactor rt_detr rt_detr_v2 d_fine to updated library standards
yonigozlan 0d6115c
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 4bc6b5e
fix repo
yonigozlan e5cf22a
Fix test_reverse_loading_mapping test
yonigozlan b2419e4
use modular for RT-DETR
yonigozlan 1dddb27
refactor conditional and deformable detr
yonigozlan 534dbd3
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan e11657f
use modular for deformable_detr
yonigozlan 8625827
use modular for conditional_detr
yonigozlan dd02700
fix repo
yonigozlan bad9c69
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 6f2b302
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan d2c74bb
refactor DetrMaskHeadSmallConv
yonigozlan 57a318d
fix modular
yonigozlan d7892e9
Temporarily remove outdated copied from
yonigozlan 0e8d262
fix consistency
yonigozlan 63dc531
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 65d9d1b
Improve DetrMHAttentionMap
yonigozlan ca317d1
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 3ce2110
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 99b87d4
Fix torch functional import aliases
yonigozlan 4f2fa85
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 52827f4
fix after merge with main
yonigozlan 41a10c2
Fix missing copyrights
yonigozlan 7821c47
Refactor HybridEncoder rt_detr
yonigozlan 90741ba
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 175d4cd
tie weights fix deformable detr
yonigozlan 66ec416
Merge branch 'main' into refactor-detr
yonigozlan b254841
Merge branch 'main' into refactor-detr
yonigozlan 209f4e6
Merge branch 'main' into refactor-detr
yonigozlan 5b7a3f1
Merge remote-tracking branch 'upstream/main' into refactor-detr
yonigozlan 4fe521b
Refactor pp docs layout + fix fp16 overflow
yonigozlan 08a7308
fix modular
yonigozlan 45a9b62
fix modular
yonigozlan f15aef7
fix deformable detr tests
yonigozlan 037bbc9
Merge branch 'main' into refactor-detr
yonigozlan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it really necessary to touch the conversion scripts? I'd rather we know that the original conversion will work with our current renaming ops |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. format? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we rename all, we can be pretty liberal with the modifications on detr and the like, that's good. No other keys misnamed or that could cause annoyances?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes agreed! I think the more we refactor, the more we'll see patterns and the more wecan try to standardize weight names, especially as the new weight loaders makes it ok to iterate on this imo and not make all the modifications at once. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my dream would be all keys identical across all models when relevant hehe. Purely aesthetical though