Skip to content

Fix overriding common_kwargs defaults in processor calls #41381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yonigozlan merged 3 commits into from
Oct 8, 2025
Merged

Fix overriding common_kwargs defaults in processor calls #41381

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
221f587
set common_kwargs defaults before updating with kwargs
yonigozlan Oct 6, 2025
c2ace8b
change order to override defaults common_kwargs
yonigozlan Oct 8, 2025
033ead0
Merge branch 'main' into fix-common-kwargs
yonigozlan Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/transformers/processing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,6 +1305,13 @@ class MyProcessingKwargs(ProcessingKwargs, CommonKwargs, TextKwargs, ImagesKwarg
# pass defaults to output dictionary
output_kwargs.update(default_kwargs)

# For `common_kwargs` just update all modality-specific kwargs with same key/values
common_kwargs = ModelProcessorKwargs._defaults.get("common_kwargs", {})
common_kwargs.update(kwargs.get("common_kwargs", {}))
if common_kwargs:
for kwarg in output_kwargs.values():
kwarg.update(common_kwargs)

# update modality kwargs with passed kwargs
non_modality_kwargs = set(kwargs) - set(output_kwargs)
for modality, output_kwarg in output_kwargs.items():
Expand Down Expand Up @@ -1354,13 +1361,6 @@ class MyProcessingKwargs(ProcessingKwargs, CommonKwargs, TextKwargs, ImagesKwarg
f"Keyword argument `{key}` is not a valid argument for this processor and will be ignored."
)

# For `common_kwargs` just update all modality-specific kwargs with same key/values
common_kwargs = kwargs.get("common_kwargs", {})
common_kwargs.update(ModelProcessorKwargs._defaults.get("common_kwargs", {}))
if common_kwargs:
for kwarg in output_kwargs.values():
kwarg.update(common_kwargs)

return output_kwargs

@classmethod
Expand Down