Skip to content

Fix DAC integration tests and checkpoint conversion. #39313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebezzam merged 12 commits into from
Jul 23, 2025
+554 −308
Merged

Fix DAC integration tests and checkpoint conversion. #39313

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4cce31f
Fix DAC (slow) integration tests.
ebezzam Jul 9, 2025
716baa6
Fix DAC conversion.
ebezzam Jul 9, 2025
086f6b0
Merge branch 'main' into dac_fix
ebezzam Jul 9, 2025
9e51f6f
Address comments
ebezzam Jul 9, 2025
0addb3e
Merge branch 'main' into dac_fix
ebezzam Jul 10, 2025
e5f02a2
Sync with main, uncomment nn.utils.parametrizations.weight_norm.
ebezzam Jul 10, 2025
178c4d8
Update DAC integration tests with expected outputs.
ebezzam Jul 11, 2025
60004f5
Merge branch 'main' into dac_fix
ebezzam Jul 11, 2025
da8243b
Added info about encoder/decoder error and longer decoder outputs.
ebezzam Jul 22, 2025
36a24cb
Parameterize tests.
ebezzam Jul 23, 2025
7d27ea1
Set expected values to GitHub runners.
ebezzam Jul 23, 2025
8eb8d8e
Merge branch 'main' into dac_fix
ebezzam Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/transformers/models/dac/convert_dac_checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import fnmatch
import re

import numpy as np
import torch
import torch.nn as nn

Expand Down Expand Up @@ -240,6 +241,7 @@ def convert_checkpoint(
config.upsampling_ratios = metadata["decoder_rates"]
config.quantizer_dropout = float(metadata["quantizer_dropout"])
config.sampling_rate = sample_rate
config.hop_length = int(np.prod(config.downsampling_ratios))

model = DacModel(config)
feature_extractor = DacFeatureExtractor()
Expand Down
Loading