-
Notifications
You must be signed in to change notification settings - Fork 31.1k
fix condition where torch_dtype auto collides with model_kwargs. #39054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
we have some progress
and for this
does the dtype used changed in your previous PR? maybe I can simply update the expected output. This is probably minor issue, don't stree |
|
if you need a more detailed log, let me know |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this is expected:
we have some progress
FAILED tests/pipelines/test_pipelines_text_generation.py::TextGenerationPipelineTests::test_small_model_pt_bloom_accelerate - AssertionError: torch.bfloat16 != torch.float32
since we default to torch.bfloat16 and not float32 in the pipeline.
for the second one I think we can just update the output
|
great and thanks a lot! |
…gingface#39054) * fix condition where torch_dtype auto collides with model_kwargs. * update tests * update comment * fix --------- Co-authored-by: ydshieh <[email protected]>
…gingface#39054) * fix condition where torch_dtype auto collides with model_kwargs. * update tests * update comment * fix --------- Co-authored-by: ydshieh <[email protected]>
…gingface#39054) * fix condition where torch_dtype auto collides with model_kwargs. * update tests * update comment * fix --------- Co-authored-by: ydshieh <[email protected]>
…gingface#39054) * fix condition where torch_dtype auto collides with model_kwargs. * update tests * update comment * fix --------- Co-authored-by: ydshieh <[email protected]>
…gingface#39054) * fix condition where torch_dtype auto collides with model_kwargs. * update tests * update comment * fix --------- Co-authored-by: ydshieh <[email protected]>
…gingface#39054) * fix condition where torch_dtype auto collides with model_kwargs. * update tests * update comment * fix --------- Co-authored-by: ydshieh <[email protected]>
…gingface#39054) * fix condition where torch_dtype auto collides with model_kwargs. * update tests * update comment * fix --------- Co-authored-by: ydshieh <[email protected]>
What does this PR do?
Fixes broken tests on nightly CI