Skip to content

Conversation

@Vaibhavs10
Copy link
Member

What does this PR do?

Fixes broken tests on nightly CI

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh
Copy link
Collaborator

ydshieh commented Jun 26, 2025

we have some progress

FAILED tests/pipelines/test_pipelines_text_generation.py::TextGenerationPipelineTests::test_small_model_pt_bloom_accelerate - AssertionError: torch.bfloat16 != torch.float32

and for this

FAILED tests/pipelines/test_pipelines_image_text_to_text.py::ImageTextToTextPipelineTests::test_small_model_pt_token - AssertionError: Lists differ: [{'in[168 chars] are facing the camera, and they'}, {'input_te[192 chars]ey'}] != [{'in[168 chars] are sleeping and appear to be comfortable'}, [212 chars]le'}]

does the dtype used changed in your previous PR? maybe I can simply update the expected output. This is probably minor issue, don't stree

@ydshieh
Copy link
Collaborator

ydshieh commented Jun 26, 2025

if you need a more detailed log, let me know

Copy link
Member Author

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this is expected:

we have some progress

FAILED tests/pipelines/test_pipelines_text_generation.py::TextGenerationPipelineTests::test_small_model_pt_bloom_accelerate - AssertionError: torch.bfloat16 != torch.float32

since we default to torch.bfloat16 and not float32 in the pipeline.

for the second one I think we can just update the output

@ydshieh
Copy link
Collaborator

ydshieh commented Jun 26, 2025

great and thanks a lot!

@ydshieh ydshieh merged commit d973e62 into main Jun 26, 2025
21 checks passed
@ydshieh ydshieh deleted the vb/fix-auto branch June 26, 2025 12:52
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gingface#39054)

* fix condition where torch_dtype auto collides with model_kwargs.

* update tests

* update comment

* fix

---------

Co-authored-by: ydshieh <[email protected]>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gingface#39054)

* fix condition where torch_dtype auto collides with model_kwargs.

* update tests

* update comment

* fix

---------

Co-authored-by: ydshieh <[email protected]>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gingface#39054)

* fix condition where torch_dtype auto collides with model_kwargs.

* update tests

* update comment

* fix

---------

Co-authored-by: ydshieh <[email protected]>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gingface#39054)

* fix condition where torch_dtype auto collides with model_kwargs.

* update tests

* update comment

* fix

---------

Co-authored-by: ydshieh <[email protected]>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gingface#39054)

* fix condition where torch_dtype auto collides with model_kwargs.

* update tests

* update comment

* fix

---------

Co-authored-by: ydshieh <[email protected]>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gingface#39054)

* fix condition where torch_dtype auto collides with model_kwargs.

* update tests

* update comment

* fix

---------

Co-authored-by: ydshieh <[email protected]>
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
…gingface#39054)

* fix condition where torch_dtype auto collides with model_kwargs.

* update tests

* update comment

* fix

---------

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants