update gemma tests #38384
Merged
update gemma tests #38384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
run-slow: gemma |
Contributor
|
This comment contains run-slow, running the specified jobs: models: ['models/gemma'] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…ransformers into update_gemma_tests # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Cyrilvallez
approved these changes
May 26, 2025
Member
There was a problem hiding this comment.
LGTM thanks! This was discussed offline -> test_model_2b_bf16 and test_model_2b_sdpa were 1:1 similar so we removed the latter, and the switch from bf16 to fp16 for eager is justified by the fact that on T4 specifically (not on A100), eager gives non-sensical outputs for this prompt on bf16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
All tests now pass, except the following one
Detect and fix most
_init_weights()issues - make it work for composite models (#37070)fails
2e-3 --> 4e-3, which is larger than 3e-3.
Let's deal with this in a separate PR.