Skip to content

Make train_dataset attribute in _get_train_sampler optional #38226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 2 commits into from
May 20, 2025
Merged

Make train_dataset attribute in _get_train_sampler optional #38226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22effa8
make it optional
SunMarc May 20, 2025
a0b9e12
Merge branch 'main' into fix-bc-sampler
SunMarc May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -972,7 +972,9 @@ def _get_collator_with_removed_columns(
)
return remove_columns_collator

def _get_train_sampler(self, train_dataset) -> Optional[torch.utils.data.Sampler]:
def _get_train_sampler(self, train_dataset: Optional[Dataset] = None) -> Optional[torch.utils.data.Sampler]:
if train_dataset is None:
train_dataset = self.train_dataset
if train_dataset is None or not has_length(train_dataset):
return None

Expand Down