Skip to content

Fix FSDP + llava-next/llava-onevision #38141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arvin-xiong wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix FSDP + llava-next/llava-onevision #38141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3240048
Fix FSDP + llava-next/llava-onevision
Arvin-xiong May 15, 2025
682db2c
Merge branch 'main' into arvin/fix_llava_no_split_modules
Arvin-xiong May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/transformers/models/llava_next/modeling_llava_next.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
from ...utils import LossKwargs, auto_docstring, can_return_tuple, is_torchdynamo_compiling, logging
from ..auto import AutoModel
from .configuration_llava_next import LlavaNextConfig

from ..llama.modeling_llama import LlamaDecoderLayer
from ..clip.modeling_clip import CLIPEncoderLayer

logger = logging.get_logger(__name__)

Expand Down Expand Up @@ -245,7 +246,7 @@ class LlavaNextPreTrainedModel(PreTrainedModel):
config_class = LlavaNextConfig
base_model_prefix = ""
supports_gradient_checkpointing = True
_no_split_modules = ["LlamaDecoderLayer"]
_no_split_modules = ["LlamaDecoderLayer", "CLIPEncoderLayer"]
_skip_keys_device_placement = "past_key_values"
_supports_cache_class = True
_supports_flash_attn_2 = True
Expand Down
5 changes: 3 additions & 2 deletions src/transformers/models/llava_onevision/modeling_llava_onevision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
)
from ..auto import AutoModel
from .configuration_llava_onevision import LlavaOnevisionConfig

from ..siglip.modeling_siglip import SiglipEncoderLayer
from ..qwen2.modeling_qwen2 import Qwen2DecoderLayer

logger = logging.get_logger(__name__)

Expand Down Expand Up @@ -301,7 +302,7 @@ class LlavaOnevisionPreTrainedModel(PreTrainedModel):
config_class = LlavaOnevisionConfig
base_model_prefix = ""
supports_gradient_checkpointing = True
_no_split_modules = ["LlamaDecoderLayer"]
_no_split_modules = ["Qwen2DecoderLayer", "SiglipEncoderLayer"]
_skip_keys_device_placement = "past_key_values"
_supports_cache_class = True
_supports_flash_attn_2 = True
Expand Down