Skip to content

[pipeline] allow image-text-to-text generate from text inputs#37696

Closed
zucchini-nlp wants to merge 1 commit intohuggingface:mainfrom
zucchini-nlp:image-text-pipe
Closed

[pipeline] allow image-text-to-text generate from text inputs#37696
zucchini-nlp wants to merge 1 commit intohuggingface:mainfrom
zucchini-nlp:image-text-pipe

Conversation

@zucchini-nlp
Copy link
Member

@zucchini-nlp zucchini-nlp commented Apr 23, 2025

What does this PR do?

As per title, passing empty list of images triggers image_processor call which in turn fails. It's because we usually check for Noneness in processors

@zucchini-nlp zucchini-nlp requested a review from yonigozlan April 23, 2025 08:38
@github-actions github-actions bot marked this pull request as draft April 23, 2025 08:38
@github-actions
Copy link
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@zucchini-nlp zucchini-nlp marked this pull request as ready for review April 23, 2025 08:38
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yonigozlan
Copy link
Member

Hello @zucchini-nlp ! I have this PR that I completely forgot about #35616, but it looks like it solves this issue. Added your tests to it, sorry about that!

@zucchini-nlp
Copy link
Member Author

@yonigozlan oh oke, cool. Can it be merged soon? Gemma3 team was asking why it doesn't work so would be nice to include in next release

@yonigozlan
Copy link
Member

Yes I asked for core maintainer approval, should be merged soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants