Pin torch == 2.6 on PR CI docker images for now#37695
Conversation
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
f006ff8 to
9792ae4
Compare
Cyrilvallez
left a comment
There was a problem hiding this comment.
Thanks a lot! Should unblock our workflows!
|
@ydshieh @Cyrilvallez I backtracked from where the issue comes from: The main culprit was introduced in pytorch/pytorch#143539 by using
It just hasn't been noticed likely due to only using it on parts where the networkx version is pinned, e.g. https://github.com/pytorch/pytorch/blob/c1c8c1f8d6993e39203d4bebcdf63bef2c867de0/tools/build/bazel/requirements.in#L7 - I would suggest pinning the networkx version (<3.3) and submitting a separate issue in the torch repo. Wdyt? Edit: Seems more like |
|
Small update. It seems to be an issue from
Should not move too fast and wait if things eventually work out :) cc @ydshieh |
|
Hi @vasqu Thank you a lot of helping investigating 🤗 ❤️ .
I planned to do this so we move to torch 2.7 on CircleCI jobs, but @gante found there are some regressions and decided to keep the pin, see #37760.
Is this a suggestion to us :-) ? |
|
@gante said we can try to use torch 2.7 on CircleCI jobs. I will try to update |
|
@ydshieh No problem :) I think with the fixes on the torch side, a pin might not be necessary anymore - tested also locally for py 3.9.
Was initially meant due to torch updating their index, so it should be good now (with uv and torch/networkx). |
|
FYI: #37856 There are a few torch compile issues but we are working on it in order to move to torch 2.7 |
pin 2.6 on CircleCi images Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
torch 2.7 is out today, but it causes strange issues , see below
Let's pin 2.6 for now on CircleCI
error log