-
Notifications
You must be signed in to change notification settings - Fork 31.4k
🔴 [VLM] Add base model without head #37033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
3a87a41
i guessreverted all CdGen classes
zucchini-nlp 8d7088a
style
zucchini-nlp 95ac049
llava onevision
zucchini-nlp f0e917e
fix copies
zucchini-nlp 85b1e7a
Merge branch 'main' into vlm-base-models
zucchini-nlp 5e4d0e8
fix some tests
zucchini-nlp 02e7b6e
some more tests
zucchini-nlp c0e41e6
dump
zucchini-nlp ef70523
Merge branch 'main' into vlm-base-models
zucchini-nlp 06b8227
skip these
zucchini-nlp 5655657
nevermind, i am dumb
zucchini-nlp 083b9bc
revert fix not needed
zucchini-nlp 4fe8a82
Merge branch 'main' into vlm-base-models
zucchini-nlp 2e6caa4
fixup
zucchini-nlp d397075
Merge branch 'main' into vlm-base-models
zucchini-nlp 0d1409f
Merge branch 'main' into vlm-base-models
zucchini-nlp a32e47e
Merge branch 'main' into vlm-base-models
zucchini-nlp 5c019fe
fixup
zucchini-nlp 32a67b1
Merge remote-tracking branch 'upstream/main' into vlm-base-models
zucchini-nlp a9b3816
another fixup
zucchini-nlp 1f7172c
more fixup to make ci finally happy
zucchini-nlp 1e5ee3b
merge main
zucchini-nlp c6bfa8d
fixup after rebasing
zucchini-nlp 7631fdb
fix qwen tests
zucchini-nlp da33a04
add internVL + typos here and there
zucchini-nlp 141c102
image token index -> id
zucchini-nlp ba58575
style
zucchini-nlp 4a73546
fix init weights
zucchini-nlp 4d4ae05
Merge remote-tracking branch 'upstream/main' into vlm-base-models
zucchini-nlp 6298cc4
Merge branch 'main' into vlm-base-models
zucchini-nlp a25e02d
revert blip-2 not supported
zucchini-nlp 3bbf3fd
address comments
zucchini-nlp 8087394
Merge remote-tracking branch 'upstream/main' into vlm-base-models
zucchini-nlp 32cbc87
Merge remote-tracking branch 'upstream/main' into vlm-base-models
zucchini-nlp 43999e8
fix copies
zucchini-nlp 43639f4
revert blip2 test file as well
zucchini-nlp d31a4c9
as discussed internally, revert back CdGen models
zucchini-nlp e7ff08c
fix some tests
zucchini-nlp c265726
fix more tests for compile
zucchini-nlp db069f1
CI red
zucchini-nlp d309ead
fix copies
zucchini-nlp f5b18eb
enumerate explicitly allowed models
zucchini-nlp c58c4f2
address comments
zucchini-nlp 9971e7f
fix tests
zucchini-nlp f601c52
fixup
zucchini-nlp 4e617b4
merge main
zucchini-nlp df62bdf
style again
zucchini-nlp 2509f77
add tests for new model class
zucchini-nlp ce4374b
another fixup ( x _ x )
zucchini-nlp 24d127f
[fixup] unused attributes can be removed post-deprecation
zucchini-nlp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite brittle and breaks adapters (in peft). How would you go about this?
I'm thinking we can propagate the key_mapping to the peft integration in the from pretrained function ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since a lot of people (including me) use adapters with VLMs, that's quite a big breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For anyone looking, this was fixed!