🔴 [generate] default max_new_tokens
#36215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
gante
force-pushed
the
default_max_new_tokens
branch
from
dd05ec1 to
fc6bed8
Compare
Contributor
Author
|
closing since I'm leaving and this is massively outdated, but this [using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The default length for
generate, as of H2 2024, has been implicitlymax_new_tokens=20. This PR makes it explicit.Since we're touching default lengths, it also removes the default
min_length=0-- it is impossible to hit, the minimum length of all sequences is 1, the bos token.A few tests were updated in the process -- they were relying on default values. (Failing TF/Jax tests were removed)
Fixes #35765