[generate] move max time tests #35962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gante
commented
Jan 29, 2025
tests/generation/test_utils.py
Outdated
| model.generate(max_length=20, bos_token_id=None) | ||
|
|
||
| @slow | ||
| def test_max_time(self): |
Contributor
Author
There was a problem hiding this comment.
(this is almost a copy from the gpt2 test. the last assertion was incorrect, and it is fixed here)
ydshieh
approved these changes
Jan 29, 2025
Collaborator
ydshieh
left a comment
ydshieh
left a comment
There was a problem hiding this comment.
Thanks.
(not sure class TokenHealingTestCase is the best class for this test, but it's super nit ...)
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
@ydshieh it is not 🙈 moving to the right class Thank you for noticing it! |
bursteratom
pushed a commit
to bursteratom/transformers
that referenced
this pull request
Feb 5, 2025
* move max time tests to their right place * move test to the right place
elvircrn
pushed a commit
to elvircrn/transformers
that referenced
this pull request
Feb 13, 2025
* move max time tests to their right place * move test to the right place
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
* move max time tests to their right place * move test to the right place
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
2-in-1 PR:
generate()'smax_timeflag from specific models to the generation integration tests. It is ageneratefeature, and not a model featuregpt2had an incorrect assertion(found while working on #35802 )