Skip to content

Conversation

@eustlb
Copy link
Contributor

@eustlb eustlb commented Jan 17, 2025

What does this PR do?

Fixes #33498 #35524

Handles two unnecessary warnings for the ASR pipeline:

  • attention mask related: need to set return_attention_mask=True in chunk_iter. Its done anyway when not using chunk_length_s parameter (here)
  • warning triggered when using deprecated input name for Whisper.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eustlb eustlb merged commit 9c8d3a7 into huggingface:main Jun 27, 2025
20 checks passed
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* return attention mask

* use correct model input name

* fix

* make
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* return attention mask

* use correct model input name

* fix

* make
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* return attention mask

* use correct model input name

* fix

* make
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* return attention mask

* use correct model input name

* fix

* make
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* return attention mask

* use correct model input name

* fix

* make
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* return attention mask

* use correct model input name

* fix

* make
zaristei pushed a commit to zaristei/transformers that referenced this pull request Sep 9, 2025
* return attention mask

* use correct model input name

* fix

* make
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Oct 21, 2025
## Description
Fix whisper hook generate decorator arguments passing
Transformer change introduced in:
huggingface/transformers#35753 (4.54.1 release)
Tested with 4.53, 4.55 transformers

<!--- Jira ticket number (e.g., 123). Delete if there's no ticket. Don't
include full link or project name. -->
Ticket: 174921


## Checklist:
- [x] This patch fully addresses the ticket. <!--- If follow-up pull
requests are needed, specify in description. -->
github-merge-queue bot pushed a commit to openvinotoolkit/openvino.genai that referenced this pull request Oct 21, 2025
## Description
Fix whisper hook generate decorator arguments passing
Transformer change introduced in:
huggingface/transformers#35753 (4.54.1 release)
Tested with 4.53, 4.55 transformers

<!--- Jira ticket number (e.g., 123). Delete if there's no ticket. Don't
include full link or project name. -->
Ticket: 174921


## Checklist:
- [x] This patch fully addresses the ticket. <!--- If follow-up pull
requests are needed, specify in description. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants