Added support for GraniteForSequenceClassification#35720
Open
berserkr wants to merge 1 commit intohuggingface:mainfrom
Open
Added support for GraniteForSequenceClassification#35720berserkr wants to merge 1 commit intohuggingface:mainfrom
berserkr wants to merge 1 commit intohuggingface:mainfrom
Conversation
Rocketknight1
approved these changes
Jan 16, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Overall LGTM, but the class might need test coverage! Can you copy/adapt tests from another SequenceClassification CLM class?
Author
|
@Rocketknight1 will take a look and add the test. Thank you! |
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Granite is now a modular supported file! Thus should be done in the modular file!
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for sequence classification for granite-series models. It is based on the Llama for Seq. Classification implementation. Has been tested with various reward model implementations.