Add mean_resizing for every VLMs' resizing_token_embeddings() #35717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YenFuLin
requested review from
ArthurZucker,
Rocketknight1,
eustlb,
qubvel,
yonigozlan and
zucchini-nlp
as code owners
5 tasks
Rocketknight1
approved these changes
Jan 16, 2025
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
Yes, this looks good to me! Mean resizing should be the default for most token embeddings in future, and this PR cleanly passes the option through to the super method.
cc @ArthurZucker for core maintainer review!
ArthurZucker
reviewed
Feb 3, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Yep very good catch! This was already on by default, so all good not breaking!˜
elvircrn
pushed a commit
to elvircrn/transformers
that referenced
this pull request
Feb 13, 2025
…gface#35717) * refine all resize_token_embedding() * ruff format * hotfix
sbucaille
pushed a commit
to sbucaille/transformers
that referenced
this pull request
Feb 16, 2025
…gface#35717) * refine all resize_token_embedding() * ruff format * hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The function, resizing_token_embeddings(), is defined in model_utils.py, but in some VLMs overrided it and forget adding this new argument, mean_resizing, so that user cannot change mean_resizing value. However, I think this argument shall be flexible to VLMs so that I refine it.
Fixes #35357
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.