-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Fix flaky test_beam_search_low_memory
#35611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ) | ||
| self.assertListEqual(low_output.tolist(), high_output.tolist()) | ||
| # The two outputs must match and their shape must be as expected | ||
| self._check_similar_generate_outputs(low_output, high_output) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still required, otherwise 1% of chance to fail for Emu3Vision2TextModelTest
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
zucchini-nlp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This is a bit nasty but irrelevant to this PR. Will merge and try to fix the above one next week. |
|
Thanks. The tracker is more for batching tests, but I will check with #35564 next week |
What does this PR do?
test_beam_search_low_memoryis very flaky forEmu3Vision2TextModelTest.The 3 fixes in this PR are all necessary to have 0 failure in a suite of 100 runs.
set_xxx_less_flakymethods_check_similar_generate_outputsThe final version run 500 times without failure.