Fix CI

[Cyrilvallez]

#34858 modified Llama, but Aria relying on Llama got merged in the meantime. This correctly reapplies modular to Aria (order of RotaryEmbedding got changed because now the Attention does not need it anymore, thus it got closer to the class actually needing it)

[ydshieh]

We probably also need to check how check_modular_conversion works to avoid it passes on PR but fail on main. But that could be in another PR and by me or anyone wants to work on it.

[ydshieh]

BTW, it's always a good idea to trigger a slow CI :-)

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[Cyrilvallez]

Humm, it seems very tricky to always avoid race conditions, it would probably require some check at merge time 🤔 I thought about this becoming an issue as we scale modular, but this is already an issue with the "copied from" (except if there is additional CI magic for copied from?). Here's the scenario:

• last commit on 🧹 Remove deprecated RotaryEmbedding parts in the Attention layers #34858 pass all CIs as it should
• In the meantime, Add Aria #34157 is merged, relying on actual library version of Llama (not the modified one in 🧹 Remove deprecated RotaryEmbedding parts in the Attention layers #34858)
• 🧹 Remove deprecated RotaryEmbedding parts in the Attention layers #34858 is approved and merged (without any new commits, thus no new CI check)
• As Llama was modified in 🧹 Remove deprecated RotaryEmbedding parts in the Attention layers #34858, Aria version is not longer up-to-date

[ArthurZucker]

Thanks

[ydshieh]

@Cyrilvallez Thanks for explaining. Yes, this happens from time to time. There is Update branch button, but click it all the time is also frustrating. We will try to think of solutions.