Fix CI slack reporting issue #34833
Merged
Fix CI slack reporting issue #34833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Nov 20, 2024
Comment on lines
+2405
to
+2420
| lines = exception_message.split("\n") | ||
| # Add a first line with more informative information instead of just `= test session starts =`. | ||
| # This makes the `short test summary info` section more useful. | ||
| if "= test session starts =" in lines[0]: | ||
| text = "" | ||
| for line in lines[1:]: | ||
| if line.startswith("FAILED "): | ||
| text = line[len("FAILED ") :] | ||
| text = "".join(text.split(" - ")[1:]) | ||
| elif line.startswith("=") and line.endswith("=") and " failed in " in line: | ||
| break | ||
| elif len(text) > 0: | ||
| text += f"\n{line}" | ||
| text = "(subprocess) " + text | ||
| lines = [text] + lines | ||
| exception_message = "\n".join(lines) |
Collaborator
Author
There was a problem hiding this comment.
currently, what is shown in the (final) short test summary info is something like
/transformers/src/transformers/testing_utils.py:2420: ==== test session starts ====
which is not very informative.
And for the same test, we get two FAILED in the log: one from the subprocess and another one is the original pytest process. This causes slack CI report script fails.
Collaborator
There was a problem hiding this comment.
ah got it thanks for explaining
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Nov 20, 2024
Comment on lines
+2405
to
+2420
| lines = exception_message.split("\n") | ||
| # Add a first line with more informative information instead of just `= test session starts =`. | ||
| # This makes the `short test summary info` section more useful. | ||
| if "= test session starts =" in lines[0]: | ||
| text = "" | ||
| for line in lines[1:]: | ||
| if line.startswith("FAILED "): | ||
| text = line[len("FAILED ") :] | ||
| text = "".join(text.split(" - ")[1:]) | ||
| elif line.startswith("=") and line.endswith("=") and " failed in " in line: | ||
| break | ||
| elif len(text) > 0: | ||
| text += f"\n{line}" | ||
| text = "(subprocess) " + text | ||
| lines = [text] + lines | ||
| exception_message = "\n".join(lines) |
Collaborator
There was a problem hiding this comment.
ah got it thanks for explaining
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* fix * fix * fix * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#34812 causes the slack report fail to be sent.
This PR fixes this issue (a bit hacky)