Skip to content

Update checks for torch.distributed.tensor to require torch >= 2.5 #34816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 7 commits into from
Nov 22, 2024
Merged

Update checks for torch.distributed.tensor to require torch >= 2.5 #34816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f6321b
Update checks for torch.distributed.tensor
loadams Nov 19, 2024
e1f6ff7
Merge branch 'main' into loadams/update-torch-2.5-check
loadams Nov 19, 2024
b73fe96
Update PR with feedback
loadams Nov 21, 2024
0e60fbe
Formatting fix for import order
loadams Nov 21, 2024
e6d6ca9
Merge branch 'main' into loadams/update-torch-2.5-check
loadams Nov 21, 2024
e6d546c
Remove unused function
loadams Nov 21, 2024
e72ee14
Merge branch 'loadams/update-torch-2.5-check' of https://github.com/l…
loadams Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transformers/modeling_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
find_pruneable_heads_and_indices,
id_tensor_storage,
is_torch_greater_or_equal_than_1_13,
is_torch_greater_or_equal_than_2_4,
prune_conv1d_layer,
prune_layer,
prune_linear_layer,
Expand Down Expand Up @@ -90,6 +89,7 @@
is_peft_available,
is_remote_url,
is_safetensors_available,
is_torch_greater_or_equal,
is_torch_sdpa_available,
is_torch_xla_available,
logging,
Expand Down Expand Up @@ -5032,7 +5032,7 @@ def tensor_parallel(self, device_mesh):
device_mesh (`torch.distributed.DeviceMesh`):
The device mesh to use for tensor parallelism.
"""
if not is_torch_greater_or_equal_than_2_4:
if not is_torch_greater_or_equal("2.5"):
raise EnvironmentError("tensor parallel is only supported for `torch>=2.5`.")

# Tensor parallelize a nn.Module based on the `_tp_plan` attribute of the module.
Expand Down
4 changes: 2 additions & 2 deletions src/transformers/pytorch_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
from safetensors.torch import storage_ptr, storage_size
from torch import nn

from .utils import is_torch_xla_available, logging
from .utils import is_torch_greater_or_equal, is_torch_xla_available, logging


ALL_LAYERNORM_LAYERS = [nn.LayerNorm]
Expand All @@ -39,7 +39,7 @@
is_torch_greater_or_equal_than_1_12 = parsed_torch_version_base >= version.parse("1.12")


if is_torch_greater_or_equal_than_2_4:
if is_torch_greater_or_equal("2.5"):
from torch.distributed.tensor import Replicate
from torch.distributed.tensor.parallel import (
ColwiseParallel,
Expand Down