fix(wandb): pass fake dataset to avoid exception in trainer (see #34455)#34720
Merged
LysandreJik merged 1 commit intohuggingface:mainfrom Nov 15, 2024
Merged
Conversation
Member
Member
|
Ah, my bad, I see where this one is different. There are a few files which are changed which shouldn't be; do you mind keeping the diff only to the fix here? Thank you! |
4113d93 to
657d544
Compare
Contributor
Author
|
@LysandreJik |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR passes a fake evaluation dataset for the initialisation of the
fake_trainerof WandB.This is necessary, since the init of the
Trainerchecks if aneval_strategyis set and raises an error if theeval_datasetis missing.This issue is documented in #34701.
The fix here is similar to the one in #34455.
Fixes # (issue)
["fake"]aseval_datasetduring initialisation offake_trainerfor saving purposes of WandB.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc