Skip to content

FIX: Broken repr of TorchAoConfig #34560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LysandreJik merged 1 commit into from
Nov 5, 2024
+9 −1
Merged

FIX: Broken repr of TorchAoConfig #34560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/transformers/utils/quantization_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,8 @@ def get_apply_tensor_subclass(self):
return _STR_TO_METHOD[self.quant_type](**self.quant_type_kwargs)

def __repr__(self):
return f"{self.quant_type}({', '.join(str(k) + '=' + str(v) for k, v in self.kwargs.items())})"
config_dict = self.to_dict()
return f"{self.__class__.__name__} {json.dumps(config_dict, indent=2, sort_keys=True)}\n"
Copy link
Member

@Rocketknight1 Rocketknight1 Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this is the tiniest nit ever, but do reprs normally end in \n?

Copy link
Member Author

@BenjaminBossan BenjaminBossan Nov 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it looks unnecessary, but I copied this 1:1 from here for consistency:

transformers/src/transformers/utils/quantization_config.py

Lines 285 to 287 in e2ac16b

def __repr__(self):
config_dict = self.to_dict()
return f"{self.__class__.__name__} {json.dumps(config_dict, indent=2, sort_keys=True)}\n"



@dataclass
Expand Down
7 changes: 7 additions & 0 deletions tests/quantization/torchao_integration/test_torchao.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ def test_post_init_check(self):
with self.assertRaisesRegex(ValueError, "Unexpected keyword arg"):
_ = TorchAoConfig("int4_weight_only", group_size1=32)

def test_repr(self):
"""
Check that there is no error in the repr
"""
quantization_config = TorchAoConfig("int4_weight_only", modules_to_not_convert=["conv"], group_size=8)
repr(quantization_config)


@require_torch_gpu
@require_torchao
Expand Down