🔴 🔴 fix query_pre_attn_scalar different of num_heads in default gemma2 config#34540
Merged
🔴 🔴 fix query_pre_attn_scalar different of num_heads in default gemma2 config#34540
query_pre_attn_scalar different of num_heads in default gemma2 config#34540Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Oct 31, 2024
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks, can you add some 🔴 to the PR name! as this is breaking!
molbap
changed the title
query_pre_attn_scalar different of num_heads in default gemma2 configquery_pre_attn_scalar different of num_heads in default gemma2 config
molbap
changed the title
query_pre_attn_scalar different of num_heads in default gemma2 configquery_pre_attn_scalar different of num_heads in default gemma2 config
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…emma2 config (huggingface#34540) * fix query_pre_attn_scalar different of num_heads in default config * propagate modular changes * fix copies * fix modular copies * fix copies? * correct copies fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
as per title. Previous default config was a nonworking default config, new defaults are aligned with gemma2-2b-it.
@ArthurZucker