MPS: isin_mps_friendly can support 0D tensors#34538
Merged
gante merged 5 commits intohuggingface:mainfrom Nov 4, 2024
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Oct 31, 2024
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
Do we need a patch for this? 🤗
Contributor
Author
I don't think so, it's quite niche 🤔 If we make a patch, yes, let's include it :D |
ArthurZucker
approved these changes
Nov 4, 2024
Comment on lines
+325
to
+327
| test_elements = torch.tensor(test_elements) | ||
| if test_elements.ndim == 0: | ||
| test_elements = test_elements.unsqueeze(0) |
Collaborator
There was a problem hiding this comment.
we ought to open the issue on pytorch / link the tracker !
Contributor
Author
There was a problem hiding this comment.
On torch >=2.4 this is fixed, i.e. torch.isin is supported with mps
(in other words, this fix only affects older versions of torch) 🤗
|
Thanks @gante for using my approach. |
ArthurZucker
pushed a commit
that referenced
this pull request
Nov 5, 2024
* apply fix * tested * make fixup
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* apply fix * tested * make fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #33786
Applies the fix in
isin_mps_friendlyas suggested by @Swastik-Swarup-Dash here