Remove unused test_dataset#34516
Merged
Rocketknight1 merged 2 commits intohuggingface:mainfrom Nov 5, 2024
thisisiron:main
Merged
Remove unused test_dataset#34516Rocketknight1 merged 2 commits intohuggingface:mainfrom thisisiron:main
Rocketknight1 merged 2 commits intohuggingface:mainfrom
thisisiron:main
Conversation
Rocketknight1
approved these changes
Oct 30, 2024
Member
Rocketknight1
left a comment
Rocketknight1
left a comment
There was a problem hiding this comment.
At first I was going to object, but you're completely right, those args aren't actually used anywhere in the example, good spot.
cc @ArthurZucker @LysandreJik for core maintainer review!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Nov 5, 2024
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Thanks! Cool to clean this up, thanks @thisisiron
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes unused code related to the test dataset, improving code clarity.
Fixes # (issue)
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@amyeroberts, @qubvel