Merged
Conversation
Member
|
cc @stevhliu |
stevhliu
reviewed
Oct 30, 2024
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Thanks for updating! Feel free to mark as ready whenever you're ready :)
| Check more approaches for [oneccl_bind_pt installation](https://github.com/intel/torch-ccl). | ||
| Versions of oneCCL and PyTorch must match. | ||
|
|
||
| <Tip warning={true}> |
Member
There was a problem hiding this comment.
Need to also delete the closing </Tip> tag
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Contributor
Author
|
Hi @stevhliu . Thanks for your review. I have fixed all the comments, now it's ready to merge :) |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* update doc * Update docs/source/en/perf_train_cpu.md Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com> * delete closing tip --------- Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CPU doc