Add support for modifying Processor Kwargs in modular#34477
Closed
yonigozlan wants to merge 3 commits intohuggingface:mainfrom
Closed
Add support for modifying Processor Kwargs in modular#34477yonigozlan wants to merge 3 commits intohuggingface:mainfrom
yonigozlan wants to merge 3 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
16 tasks
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey hey! Sorry, as you saw, @Cyrilvallez is refactoring the modular, this should now be fixed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for modifying
ProcessingKwargs,ImagesKwargsandTextKwargsin modular. It is currently needed for ColPali, and I think it's nice to have in general, as it could be useful for other multimodal models in the future. Addedmodular_new_kwargs_model.pyto illustrate the need.Also:
super()would be kept after copying the parent function, when it should be removed.On that last point, I also added the modular examples to the default call of
check_modular_conversion, as otherwise, the modular examples aren't automatically updated when changes are made tomodular_model_converter, which makes it hard to trace when issues are introduced. It does make the recurrent checks such as fix-copies heavier though, so not sure if there's a better way to do this.Who can review?
@ArthurZucker